[Mlir-commits] [mlir] [mlir][vector] Add tests for `TransferWritePermutationLowering` (PR #95529)

Hugo Trachino llvmlistbot at llvm.org
Fri Jun 14 07:41:52 PDT 2024


================
@@ -1,14 +1,81 @@
 // RUN: mlir-opt %s --transform-interpreter --split-input-file | FileCheck %s
 
 ///----------------------------------------------------------------------------------------
-/// vector.transfer_write
+/// vector.transfer_write -> vector.transpose + vector.transfer_read
----------------
nujaa wrote:

Maybe naming the actual pattern being tested here `TransferWritePermutationLowering` makes sense.

Overall, I find the name of this pattern maybe a bit confusing. Technically, we are not really lowering anything. we are _hoisting out_ a transpose from the permutation map. 
If the scope of this MR is to add tests, I will keep this remark for the upcoming rework already discussed.

https://github.com/llvm/llvm-project/pull/95529


More information about the Mlir-commits mailing list