[Mlir-commits] [mlir] [mlir][scf]: Copy old attributes of old ForOp in replaceWithAdditionalYields (PR #95502)

Aviad Cohen llvmlistbot at llvm.org
Fri Jun 14 01:56:15 PDT 2024


AviadCo wrote:

> I am not sure just copying the attributes works. Can you try [this](https://github.com/llvm/llvm-project/blob/4ab37e430d960b975bfdaf95516a39ea3468f7a1/mlir/include/mlir/Dialect/Utils/StructuredOpsUtils.h#L159) method.

thanks for the review, I used `getPrunedAttributeList` and also moved it near the loop creation, the scf::ForOp::build (doesn't accept attribtues or creation)

https://github.com/llvm/llvm-project/pull/95502


More information about the Mlir-commits mailing list