[Mlir-commits] [flang] [llvm] [mlir] [Flang][OpenMP][MLIR] Fix common block mapping for regular and declare target link (PR #91829)

[llvmlistbot at llvm.org]

agozillon wrote:

Rebased and fixed conflicts on the PR and updated this PR on top of the replaceConstant PR which upgrades the variation I had in this PR. Basically just simplifies this PR by 30-40 lines. 

However, I did encounter a bit of an issue that seems unrelated to this PR that's arisen between now and the original opening of this PR, it seems that utilising the common block /var/ syntax inside of the map clause will crash the compiler in the decomposer, it's not picked up by any of the upstream tests at the moment as the main map clause + common block tests are semantic checks at the moment, and the act of emitting semantic erroring in the one test I seen prevents the test from progressing to the point it would crash! I've talked to @kparzysz and will open up a very small PR to fix it in a little bit.

However, in the meantime, please do feel free to review this PR and if you see errors in the CI in the meantime, that's likely the cause.

https://github.com/llvm/llvm-project/pull/91829