[Mlir-commits] [mlir] [mlir][scf] Fix scf.forall to scf.parallel pass walker (PR #95385)

[Spenser Bauman]

================
@@ -71,8 +71,9 @@ struct ForallToParallelLoop final
 
     parentOp->walk([&](scf::ForallOp forallOp) {
       if (failed(scf::forallToParallelLoop(rewriter, forallOp))) {
-        return signalPassFailure();
+        return WalkResult::skip();
----------------
sabauma wrote:

> This is a question of semantics for the pass though, and unfortunately this pass does not even have a description!

The lack of description is my fault. My original intention was to error out when `scf.forall` cannot be lowered. I don't think it makes sense to run this transform before bufferization, and after bufferization all `scf.forall` operations should produce no results.

https://github.com/llvm/llvm-project/pull/95385