[Mlir-commits] [mlir] [mlir][scf] Fix scf.forall to scf.parallel pass walker (PR #95385)

Mehdi Amini llvmlistbot at llvm.org
Thu Jun 13 09:50:16 PDT 2024


================
@@ -71,8 +71,9 @@ struct ForallToParallelLoop final
 
     parentOp->walk([&](scf::ForallOp forallOp) {
       if (failed(scf::forallToParallelLoop(rewriter, forallOp))) {
-        return signalPassFailure();
+        return WalkResult::skip();
----------------
joker-eph wrote:

`notifyMatchFailure` is a debug function. This is a question of semantics for the pass though, and unfortunately this pass does not even have a description! 
Can we start here and document the pass behavior before changing it?

https://github.com/llvm/llvm-project/pull/95385


More information about the Mlir-commits mailing list