[Mlir-commits] [mlir] [mlir][EmitC] Model lvalues as a type in EmitC (PR #91475)

[Gil Rapaport]

================
@@ -61,6 +61,9 @@ void mlir::emitc::buildTerminatedBody(OpBuilder &builder, Location loc) {
 bool mlir::emitc::isSupportedEmitCType(Type type) {
   if (llvm::isa<emitc::OpaqueType>(type))
     return true;
+  if (auto lType = llvm::dyn_cast<emitc::LValueType>(type))
+    // lvalue types are only allowed in a few places.
+    return false;
----------------
aniragil wrote:

As the function seems to have a mostly opt-in style I'd try to keep it consistent in defaulting to false unless explicitly accepted.

https://github.com/llvm/llvm-project/pull/91475