[Mlir-commits] [mlir] [mlir][scf] Fix scf.forall to scf.parallel pass walker (PR #95385)
Mehdi Amini
llvmlistbot at llvm.org
Thu Jun 13 06:14:57 PDT 2024
================
@@ -71,8 +71,9 @@ struct ForallToParallelLoop final
parentOp->walk([&](scf::ForallOp forallOp) {
if (failed(scf::forallToParallelLoop(rewriter, forallOp))) {
- return signalPassFailure();
+ return WalkResult::skip();
----------------
joker-eph wrote:
Is this a failure? Why remove the `signalPassFailure()`?
There is also likely a missing error message before `signalPassFailure()` here (we shouldn't fail silently).
https://github.com/llvm/llvm-project/pull/95385
More information about the Mlir-commits
mailing list