[Mlir-commits] [mlir] [MLIR][Vector]Generalize DropUnitDimFromElementwiseOps (PR #92934)
Benjamin Maxwell
llvmlistbot at llvm.org
Thu Jun 13 02:54:03 PDT 2024
================
@@ -1607,7 +1607,28 @@ struct ChainedReduction final : OpRewritePattern<vector::ReductionOp> {
}
};
-/// For vectors with either leading or trailing unit dim, replaces:
+// Scalable unit dimensions are not supported. Folding such dimensions would
+// require "shifting" the scalable flag onto some other fixed-width dim (e.g.
+// vector<[1]x4xf32> -> vector<[4]xf32>). This could be implemented in the
+// future.
+static VectorType dropNonScalableUnitDimFromType(VectorType inVecTy) {
+ auto newVecBuilder = VectorType::Builder(inVecTy);
----------------
MacDue wrote:
This is unused:
```suggestion
```
https://github.com/llvm/llvm-project/pull/92934
More information about the Mlir-commits
mailing list