[Mlir-commits] [mlir] [mlir][gpu] Add metadata attributes for storing kernel metadata in GPU objects (PR #95292)

[Fabian Mora]

fabianmcg wrote:

> Right, I was pointing at the "input" and I think your answer described the "output" right"?
> I'm trying to avoid a complete default that just pass-through all discardable attributes.

Right now they are just 2 dict attrs wrapped inside `#gpu.kernel`, so they don't default to all attributes, it just allows to have as many attributes as possible -including all function attributes.

However, I agree that abetter design is making several fields, like symbol name, type, etc mandatory and then a generic dictionary with optional metadata.

My idea is to add in a future PR, attribute interfaces to NVVM and ROCDL to extract that optional metadata depending in the target. I'm just trying to avoid creating the same attribute in NVVM and ROCDL.

https://github.com/llvm/llvm-project/pull/95292