[Mlir-commits] [mlir] [mlir][gpu] Pass GPU module to `TargetAttrInterface::createObject`. (PR #94910)

Fabian Mora llvmlistbot at llvm.org
Wed Jun 12 17:13:00 PDT 2024


fabianmcg wrote:

> That seems... surprising to me, and kind of arbitrary. Who's consuming this then? Why isn't it on the target attr in the first place?

That wasn't their default behavior, I was making it so the approach was testable, because there are not that many ways to test this PR. However, with https://github.com/llvm/llvm-project/pull/95292 this PR will be testable with the ROCDL  attribute.

https://github.com/llvm/llvm-project/pull/94910


More information about the Mlir-commits mailing list