[Mlir-commits] [mlir] [mlir][arith] Add memref alias folders for expand/collapse_shape for vector load/store (PR #95223)

Markus Böck llvmlistbot at llvm.org
Wed Jun 12 06:03:05 PDT 2024


https://github.com/zero9178 approved this pull request.

Generally LGTM with comments addressed.

Is the ´[arith]` in the title on purpose or just a copy-paste error or typo? Given that these patterns are in MemRef. 

Side node: Its funny to see type switches when its already templated on the operation type and could be `if constexpr`s. Don't view this as an actionable item tho :)

https://github.com/llvm/llvm-project/pull/95223


More information about the Mlir-commits mailing list