[Mlir-commits] [mlir] 638d968 - mlir/Presburger: guard dump function; fix buildbot (#95218)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Wed Jun 12 03:00:29 PDT 2024


Author: Ramkumar Ramachandra
Date: 2024-06-12T11:00:25+01:00
New Revision: 638d96843893f6981c9af8c501f6999cc7db15e6

URL: https://github.com/llvm/llvm-project/commit/638d96843893f6981c9af8c501f6999cc7db15e6
DIFF: https://github.com/llvm/llvm-project/commit/638d96843893f6981c9af8c501f6999cc7db15e6.diff

LOG: mlir/Presburger: guard dump function; fix buildbot (#95218)

Follow up on 76030dc (mlir/Presburger/MPInt: move into llvm/ADT) to
guard a function in Fraction.h with !NDEBUG || LLVM_ENABLE_DUMP, since
the call to the corresponding function in DynamicAPInt is guarded
similarly. This patch fixes the build when mlir is built with this
configuration.

Added: 
    

Modified: 
    mlir/include/mlir/Analysis/Presburger/Fraction.h

Removed: 
    


################################################################################
diff  --git a/mlir/include/mlir/Analysis/Presburger/Fraction.h b/mlir/include/mlir/Analysis/Presburger/Fraction.h
index f4f1be97147bf..6be132058e6ca 100644
--- a/mlir/include/mlir/Analysis/Presburger/Fraction.h
+++ b/mlir/include/mlir/Analysis/Presburger/Fraction.h
@@ -52,15 +52,24 @@ struct Fraction {
     return num / den;
   }
 
-  llvm::raw_ostream &print(llvm::raw_ostream &os) const {
-    return os << "(" << num << "/" << den << ")";
-  }
-
   /// The numerator and denominator, respectively. The denominator is always
   /// positive.
   DynamicAPInt num{0}, den{1};
+
+#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
+  llvm::raw_ostream &print(llvm::raw_ostream &os) const {
+    return os << "(" << num << "/" << den << ")";
+  }
+#endif
 };
 
+#if !defined(NDEBUG) || defined(LLVM_ENABLE_DUMP)
+inline llvm::raw_ostream &operator<<(llvm::raw_ostream &os, const Fraction &x) {
+  x.print(os);
+  return os;
+}
+#endif
+
 /// Three-way comparison between two fractions.
 /// Returns +1, 0, and -1 if the first fraction is greater than, equal to, or
 /// less than the second fraction, respectively.
@@ -156,12 +165,6 @@ inline Fraction &operator*=(Fraction &x, const Fraction &y) {
   x = x * y;
   return x;
 }
-
-inline llvm::raw_ostream &operator<<(llvm::raw_ostream &os, const Fraction &x) {
-  x.print(os);
-  return os;
-}
-
 } // namespace presburger
 } // namespace mlir
 


        


More information about the Mlir-commits mailing list