[Mlir-commits] [mlir] [mlir][TilingInterface] Update documentation for `TilingInterface.td`. (PR #95178)
Quinn Dawkins
llvmlistbot at llvm.org
Tue Jun 11 16:44:13 PDT 2024
================
@@ -49,19 +86,18 @@ def TilingInterface : OpInterface<"TilingInterface"> {
/*desc=*/[{
Method to generate the tiled implementation of an operation.
- The iteration space of the operation is returned by
- `getIterationDomain`. The caller provides the information of the
- tile within this iteration space whose implementation the
- caller needs.
+ Given a tile of the iteration space (as returned by
+ `getIterationDomain`), generate in-place the code that represents
+ the computation corresponding to that tile of the iteration space.
+ It is the responsibility of the implementation of this method in
+ the operation to generate the slices of the operands needed for the
+ tiled implementation.
- `offsets` provides the offset of the tile in the coordinate system
of the original iteration space, i.e., if an iteration space
- dimension had non-zero offset, it must be included in the offset
+ dimension had non-zero offset, it will be included in the offset
provided here (as opposed to zero-based offset "relative" to the
iteration space).
- `sizes` provides the size of the tile.
-
- The method returns the operation that is the tiled
- implementation.
----------------
qedawkins wrote:
Add a brief description of the return type (TilingResult) here? Explain that the implementation must return the value(s) corresponding to the result tiles, not the full operation.
https://github.com/llvm/llvm-project/pull/95178
More information about the Mlir-commits
mailing list