[Mlir-commits] [mlir] [mlir][ROCDL] Swap range metadata to range attribute (PR #94853)

Krzysztof Drewniak llvmlistbot at llvm.org
Tue Jun 11 12:10:48 PDT 2024


https://github.com/krzysz00 approved this pull request.

As a matter of not impeding progress on a deprecation, approved.

However, I'd like to ask a refactoring favor while you're here (since I ... just started writing a branch to do this). If it's not too much trouble, could you go ahead and
- Add a `RangeOpInterface` by analogy to `AliasAnalysisOpInterface` or `FastmathFlagsInterface`?
- Make the range translation code part of `IntrOpBase`, similarly (bonus points for bidirectional)
- Go mark `rocdl.workitem_id` and its fellows (all the special registers, really) with being operations that can have ranges on them
  - And get the nvvm dialect ones too

https://github.com/llvm/llvm-project/pull/94853


More information about the Mlir-commits mailing list