[Mlir-commits] [mlir] [MLIR][Vector]Generalize DropUnitDimFromElementwiseOps (PR #92934)

Andrzej WarzyƄski llvmlistbot at llvm.org
Tue Jun 11 11:28:04 PDT 2024


================
@@ -1607,7 +1607,27 @@ struct ChainedReduction final : OpRewritePattern<vector::ReductionOp> {
   }
 };
 
-/// For vectors with either leading or trailing unit dim, replaces:
+/// Drop unit dimension of the input VectorType. Scalable dimensions cannot be
+/// folded as we do not want to merge them through a shape_cast and create ill
+/// shaped scalable sizes.
----------------
banach-space wrote:

@nujaa Are you OK to update this comment as per my suggestion above? Thanks!

https://github.com/llvm/llvm-project/pull/92934


More information about the Mlir-commits mailing list