[Mlir-commits] [flang] [mlir] [MLIR][Flang][DebugInfo] Set debug info format in MLIR->IR translation (PR #95098)

Stephen Tozer llvmlistbot at llvm.org
Tue Jun 11 07:13:02 PDT 2024


SLTozer wrote:

> Why aren't any tests added to this PR?

A further patch that I intend(ed) to land very shortly afterwards would update the state of the flags would lead to this getting coverage, but I'm happy to pull this back to make sure the patch itself has proper test coverage.

> Please, could you allow more time for reviews next time?

Apologies - I'll revert the patch for now, and reopen the review for a longer period of time before landing. This looked like a hotfix situation to me based on similar changes that were approved in MLIR, but based on your comment about controlling the driver, this probably needs a slightly more involved fix.

https://github.com/llvm/llvm-project/pull/95098


More information about the Mlir-commits mailing list