[Mlir-commits] [mlir] mlir/Presburger: contribute a free-standing parser (PR #94916)

[Kunwar Grover]

https://github.com/Groverkss requested changes to this pull request.

Thank you for the PR. On an initial look, I see that you are duplicating AffineExpr inside Presburger. I don't think this is the way to go. I would instead prefer a parser that directly builds a MultiAffineFunction/AffineFunction (might need some work inside Presburger) (https://github.com/llvm/llvm-project/blob/main/mlir/include/mlir/Analysis/Presburger/PWMAFunction.h#L41) and uses that.

https://github.com/llvm/llvm-project/pull/94916