[Mlir-commits] [mlir] [mlir][Transforms] Dialect Conversion: Simplify block conversion API (PR #94866)

Markus Böck llvmlistbot at llvm.org
Sat Jun 8 13:20:57 PDT 2024


================
@@ -661,42 +662,38 @@ class ConversionPatternRewriter final : public PatternRewriter {
 public:
   ~ConversionPatternRewriter() override;
 
-  /// Apply a signature conversion to the entry block of the given region. This
-  /// replaces the entry block with a new block containing the updated
-  /// signature. The new entry block to the region is returned for convenience.
+  /// Apply a signature conversion to given block. This replaces the block with
+  /// a new block containing the updated signature. The operations of the given
+  /// block are inlined into the newly-created block, which is returned.
+  ///
   /// If no block argument types are changing, the entry original block will be
   /// left in place and returned.
----------------
zero9178 wrote:

```suggestion
  /// If no block argument types are changing, the original block will be
  /// left in place and returned.
```
(assuming this is still true)

https://github.com/llvm/llvm-project/pull/94866


More information about the Mlir-commits mailing list