[Mlir-commits] [mlir] [MLIR] Add continuous tiling to transform dialect (PR #82792)

Rolf Morel llvmlistbot at llvm.org
Fri Jun 7 04:30:00 PDT 2024


rolfmorel wrote:

> I'm open to suggestions here. Note that, despite people writing a lot of it directly, transform dialect is still an IR so some choices can be made for a compiler to reason more easily about the IR, such as param constants being operations similarly to all other constants in MLIR.

Yes, valid point - having the param constants out in front of `transform.include`s is mostly a stylistic concern and could even be useful if we were to do things to Transform IR itself.

The more serious issue we are seeing is that the current MO is for all ops whose attribute arguments we would like to abstract over are to be modified - op by op, argument by argument - to take these attributes as params as well. While the current approach works, it feels there's potentially a better mechanism for addressing this need.

As this is becoming off-topic for this PR, we will post on Discourse to start a discussion regarding better ways of dealing with the above. 

https://github.com/llvm/llvm-project/pull/82792


More information about the Mlir-commits mailing list