[Mlir-commits] [mlir] [MLIR] Add continuous tiling to transform dialect (PR #82792)

[Oleksandr Alex Zinenko]

ftynse wrote:

> The main point of interest regarding the test case is that it demonstrates how to do abstraction with the Transform dialect. That is, it shows how a higher-level transform can be implemented with the Transform dialect while the details of this implementation can be hidden. In this way, the higher-level transform's functionality is exposed basically* as if it were available like any other Transform op.
>
> (*: Note that (currently) a named sequence cannot be parametric w.r.t. attribute arguments that its contained ops take as attributes and not as params. So each op that we would like to use in named sequences - and whose attribute arguments we'd like to expose as arguments of the sequence - needs to be modified to take the relevant attributes as transform.param arguments as well. Additionally these attribute arguments need to be packaged up as params before being handed to the named sequence - see transform.param.constant right before transform.include up above. This is not ideal.)

I'm open to suggestions here. Note that, despite people writing a lot of it directly, transform dialect is still an IR so some choices can be made for a compiler to reason more easily about the IR, such as param constants being operations similarly to all other constants in MLIR.

https://github.com/llvm/llvm-project/pull/82792