[Mlir-commits] [mlir] [mlir][Transforms][NFC] Improve dialect conversion documentation (PR #94736)

[Matthias Springer]

https://github.com/matthias-springer created https://github.com/llvm/llvm-project/pull/94736

None

>From de5db33452652572a7d33f0415e0a535ec1f1700 Mon Sep 17 00:00:00 2001
From: Matthias Springer <mspringer at nvidia.com>
Date: Fri, 7 Jun 2024 10:44:12 +0200
Subject: [PATCH] [mlir][Transforms][NFC] Improve dialect conversion
 documentation

---
 mlir/include/mlir/Transforms/DialectConversion.h | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/mlir/include/mlir/Transforms/DialectConversion.h b/mlir/include/mlir/Transforms/DialectConversion.h
index 83198c9b0db54..f6c51499f271c 100644
--- a/mlir/include/mlir/Transforms/DialectConversion.h
+++ b/mlir/include/mlir/Transforms/DialectConversion.h
@@ -1088,8 +1088,9 @@ struct ConversionConfig {
 
   /// An optional listener that is notified about all IR modifications in case
   /// dialect conversion succeeds. If the dialect conversion fails and no IR
-  /// modifications are visible (i.e., they were all rolled back), no
-  /// notifications are sent.
+  /// modifications are visible (i.e., they were all rolled back), or if the
+  /// dialect conversion is an "analysis conversion", no notifications are
+  /// sent (apart from `notifyPatternBegin`/notifyPatternEnd`).
   ///
   /// Note: Notifications are sent in a delayed fashion, when the dialect
   /// conversion is guaranteed to succeed. At that point, some IR modifications