[Mlir-commits] [mlir] [mlir][loops] Add getters for multi dim loop variables in `LoopLikeOpInterface` (PR #94516)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Wed Jun 5 14:07:18 PDT 2024


srcarroll wrote:

> optional<SmallVector<OpFoldResult>> makes sense to me. Should be true for all of the methods added here.

so i'm definitely in agreement with both of you on this. but this requires a lot of changes because of the way i have named the functions. For example `scf::ForallOp` already had `getMixedUpperBound`, etc. I kept this naming convention for the interface methods.  The issue now is that everywhere this function was called, now I have to check if there is a value and then get the value. I'm personally fine with this, but wonder if anyone will be annoyed by the inconvenience. 

Any thoughts?

https://github.com/llvm/llvm-project/pull/94516


More information about the Mlir-commits mailing list