[Mlir-commits] [mlir] [mlir][vector] Use notifyMatchFailure instead of assert in VectorLinearize (PR #93590)

Artem Kroviakov llvmlistbot at llvm.org
Wed Jun 5 08:58:05 PDT 2024


================
@@ -152,9 +152,10 @@ struct LinearizeVectorExtractStridedSlice final
   matchAndRewrite(vector::ExtractStridedSliceOp extractOp, OpAdaptor adaptor,
                   ConversionPatternRewriter &rewriter) const override {
     Type dstType = getTypeConverter()->convertType(extractOp.getType());
----------------
akroviakov wrote:

Could you please provide more detail on how ShapedType would not need a cast for `cast<VectorType>(dstType).isScalable()`? AFAIK ShapedType has no `isScalable()`, I do not see other places in the pattern where we could use ShapedType's information/methods that are not provided by Type.

https://github.com/llvm/llvm-project/pull/93590


More information about the Mlir-commits mailing list