[Mlir-commits] [mlir] [mlir][scf] Extend option to yield replacement for multiple results case (PR #93144)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Wed Jun 5 06:51:14 PDT 2024


================
@@ -190,10 +190,14 @@ tileAndFuseProducerOfSlice(RewriterBase &rewriter,
 /// where `%0` had other uses as well. If not reconstructed from within the loop
 /// body, uses of `%0` could not be replaced, making it still live and the
 /// fusion immaterial.
+///
+/// The @param `yieldResultNumber` decides which result would be yield. If not
+/// given, yield all `opResult` of fused producer.
----------------
Yun-Fly wrote:

> 1. throw failure.
> 2. treat it as same as std::nullopt.
> 3. use ArraryRef{} as default argument, then no ambiguity between std::nullopt and ArraryRef{}

Select the third one as current solution.

https://github.com/llvm/llvm-project/pull/93144


More information about the Mlir-commits mailing list