[Mlir-commits] [mlir] [MLIR][NVVM][GPU] Do not expect nvidia `fatbinary` to be present (PR #94367)

[Guray Ozen]

================
@@ -246,11 +250,15 @@ std::optional<std::string> NVPTXSerializer::findTool(StringRef tool) {
     if (llvm::sys::fs::can_execute(path))
       return StringRef(path.data(), path.size()).str();
   }
-  getOperation().emitError()
-      << "Couldn't find the `" << tool
-      << "` binary. Please specify the toolkit "
-         "path, add the compiler to $PATH, or set one of the environment "
-         "variables in `NVVM::getCUDAToolkitPath()`.";
+
+  // If we reached this point we failed to find the tool.
+  if (warn_on_missing) {
+    getOperation().emitWarning()
----------------
grypp wrote:

This is behaviour change (error -> warning). In that case, if `ptxas` isn't present, the compiler gives only warning. 

https://github.com/llvm/llvm-project/pull/94367