[Mlir-commits] [mlir] Refactor LoopFuseSiblingOp and support parallel fusion (PR #94391)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Jun 4 19:04:15 PDT 2024


srcarroll wrote:

> checkFusionStructuralLegality - keep as static function for now in ParallelLoopFusion.cpp, use exisitng isSibling for transform.

as far as i can tell, this change wouldn't really benefit anything if it's not shared by pass and transform. it would just be replacing inline code with a static function. am i missing something?

as a related side note: i do think the iteration domain check should surely be shared. In which case i think having it in Utils makes sense. would you agree?

https://github.com/llvm/llvm-project/pull/94391


More information about the Mlir-commits mailing list