[Mlir-commits] [mlir] Refactor LoopFuseSiblingOp and support parallel fusion (PR #94391)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Jun 4 18:13:14 PDT 2024


srcarroll wrote:

Just want to run some organizational details through you. This is what i currently think about what header and library the functions you mentioned should live in.

`checkFusionStructuralLegality` - declare in `SCF/Utils/Utils.h`, implemented in `SCF/Utils/Utils.cpp` which will make it part of the `MLIRSCFUtils` lib
fuseParallel - declare in `SCF/Transforms/Transforms.h` to be part of the `MLIRSCFTransforms`. not sure what source this should be implemented in yet
checkParallelAliasing - i suppose for now this could be static in `ParallelLoopFusion.cpp` but i imagine this can be reused eventually. just dont have much of an opinion on it yet.

Any thoughts?

> Side note: not many folks will see this PR while it's in draft state and I'm not very familiar with the transform dialect.

i'll undraft after implementing your suggestions and ping @ftynse to take a look if he's available

https://github.com/llvm/llvm-project/pull/94391


More information about the Mlir-commits mailing list