[Mlir-commits] [mlir] Refactor LoopFuseSiblingOp and support parallel fusion (PR #94391)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Tue Jun 4 17:47:00 PDT 2024


srcarroll wrote:

so this is where the mess i mentioned really becomes a problem. there are static helpers all over the place, when a lot of these should be a part of libraries to be reused. for example there is a `isSibling` that is used for checking dominance in `SCFTransformOps.cpp`, which is much more complex than what is checked for the pass 
```
  for (Operation *user : firstPloop->getUsers())
    if (!dom.properlyDominates(secondPloop, user, /*enclosingOpOk*/ false))
      return;
 ```
 so should I move `isSibling` to some library and use for both?

https://github.com/llvm/llvm-project/pull/94391


More information about the Mlir-commits mailing list