[Mlir-commits] [mlir] [mlir][affine][Analysis] Add conservative bounds for semi-affine mods (PR #93576)

[Kunwar Grover]

================
@@ -62,6 +60,10 @@ ScalableValueBoundsConstraintSet::computeScalableBound(
   int64_t pos = scalableCstr.insert(value, dim, /*isSymbol=*/false);
   scalableCstr.processWorklist();
 
+  // Check the resulting constraints set is valid.
+  if (scalableCstr.cstr.isEmpty())
----------------
Groverkss wrote:

You should also check if `isEmpty` is the solver you want to use. There is a Simplex solver which might be better as you are going into more complex constraints (or Integer solver if you have mod/floor constraints). Have a look at this PR for more context: https://github.com/llvm/llvm-project/pull/93010

https://github.com/llvm/llvm-project/pull/93576