[Mlir-commits] [mlir] [mlir][affine][Analysis] Add conservative bounds for semi-affine mods (PR #93576)

[Andrzej Warzyński]

banach-space wrote:

 This is not really my area of expertise, but looks like all comments from @Groverkss have been addressed. Kunwar, can you take another look? This LGTM :)

> Just looking in the affine sources I found:
> 
> ```
>   /// RHS of mod is always a constant or a symbolic expression with a positive
>   /// value.
> ```
> 
> So does that mean if the (symbolic) rhs is negative for a semi-affine mod it's UB?

Do you have a link? Not supporting it might be safer - it's not obvious to me why it would be UB TBH.

https://github.com/llvm/llvm-project/pull/93576