[Mlir-commits] [mlir] [MLIR] Improve translation of DISubrange. (PR #93689)

[Abid Qadeer]

abidh wrote:

> Looks good to me.
> 
> Can you try if a PointerUnion works for the BoundType? If it is also cumbersome to use then we can go with the current solution.



> LGTM
> 
> I am not sure if the suggestion of using a PointerUnion got lost? I think that may actually be a good solution to improve type safety of the bounds type info and it is also in line with what LLVM does. Or did you try and it did also get to cumbersome to use?

I spent time on that suggestion today but I have not been able to make it work till now. Build error suggest that `PointerUnion` does not obey constraints that rest of the code is expecting. I guess some customized parsing/printing code needs to be written before it could be used. I also could not find an example of using an arbitrary type as parameter so it has mostly been trial and error.

https://github.com/llvm/llvm-project/pull/93689