[Mlir-commits] [mlir] [mlir][vector] Add `actualRank` output parameter to `createUnrollIterator()` (PR #94197)

Andrzej WarzyƄski llvmlistbot at llvm.org
Mon Jun 3 09:12:25 PDT 2024


================
@@ -86,20 +86,24 @@ bool isContiguousSlice(MemRefType memrefType, VectorType vectorType);
 ///
 /// If no leading dimensions can be unrolled an empty optional will be returned.
 ///
+/// The actual rank the vector type can be unrolled to can be discovered by
+/// passing a pointer (to an int64_t) to the optional `actualRank` parameter.
+///
----------------
banach-space wrote:

It would be good to add some context here:
* IIUC, only in the presence of scalable vectors the actual rank after unrolling might be different to `targetRank`? Please clarify.
* What happens if `actualRank != targetRank`? Does unrolling still happen? Please clarify.

https://github.com/llvm/llvm-project/pull/94197


More information about the Mlir-commits mailing list