[Mlir-commits] [mlir] [MLIR][Transforms] add eliminate-explicit-rounding pass (PR #93443)

[Jakub Kuderski]

kuhar wrote:

> I recommend merging this PR first to facilitate subsequent functionality and accuracy testing. We can then add attribute control in a later PR.

To me it seems like the current implementation is gambling on fp semantics that happens to work (with acceptable accuracy) for some specific downstream usecase. I'm not sure if it brings value to anyone else if we upstream it in the current form. In general, I'm in favor of keeping similar code downstream until there's a more principled solution or compelling upstream usecase.

https://github.com/llvm/llvm-project/pull/93443