[Mlir-commits] [mlir] [MLIR][Vector]Generalize DropUnitDimFromElementwiseOps (PR #92934)

Andrzej WarzyƄski llvmlistbot at llvm.org
Mon Jun 3 02:11:10 PDT 2024


================
@@ -1607,7 +1607,24 @@ struct ChainedReduction final : OpRewritePattern<vector::ReductionOp> {
   }
 };
 
-/// For vectors with either leading or trailing unit dim, replaces:
+VectorType dropNonScalableUnitDimType(VectorType inVecTy) {
----------------
banach-space wrote:

Please document this hook. In particular, why only "NonScalableUnitDim"s are folded?

```suggestion
static VectorType dropNonScalableUnitDimType(VectorType inVecTy) {
```

https://github.com/llvm/llvm-project/pull/92934


More information about the Mlir-commits mailing list