[Mlir-commits] [mlir] [mlir][vector] Add ElementwiseToOuterproduct (PR #93664)

Andrzej WarzyƄski llvmlistbot at llvm.org
Mon Jun 3 01:52:26 PDT 2024


https://github.com/banach-space commented:

Thanks Hugo!!

Naming is hard, but let me try ... To me, `FoldArithToVecOouterProd` would make more sense than `ElementwiseToOuterproduct`. I just feel that "Elementwise" is a very broad category and this new pattern is not really matching `OpTrait::Elementwise`. 

More comments inline.

https://github.com/llvm/llvm-project/pull/93664


More information about the Mlir-commits mailing list