[Mlir-commits] [mlir] Reimplementing target description concept using DLTI attribute (PR #92138)

[Fabian Mora]

fabianmcg wrote:

@nhasabni great work!
Quick couple of comments/questions:

1. How do you suggest we model devices of devices (clusters) and so on? 
With the current setup its not entirely evident to me how to model them (maybe I got something wrong in the implementation).

2. Why is the device ID mandatory?
I get its usefulness, for example, describing a system down to its NUMA topology. However, not all system descriptions will care about that, and in those instances it might be highly inconvenient having it mandatory, as systems with the same devices but with different device ids are not equal. I would consider making it optional.

3. Do we want to have methods like `getSpecForL1CacheSizeInBytes` hardcoded in the attribute/interface?
If we have L1, why not L2, l3? I would argue those queries belong to the entries of the spec and not in the attribute.

4. Shouldn't systems have entries as well? Or let me rephrase it, how would you model the amount of shared HBM in a system, is it a device?

https://github.com/llvm/llvm-project/pull/92138