[Mlir-commits] [mlir] [mlir][SCF] Deprecate `linalg::tileToForallOp` and `linalg::tileToForallOpUsingTileSizes` (PR #91878)
Quinn Dawkins
llvmlistbot at llvm.org
Sat Jun 1 09:40:25 PDT 2024
qedawkins wrote:
> I believe we're using this in our project. If there's a better way, we're all ears, and can change our code to match, but it would be good to understand the alternatives.
I asked about this above, and the plan was to leave clear instructions on how to move to the new SCF API. We had one remaining use in IREE that I prefetched and migrated here: https://github.com/iree-org/iree/commit/3f51d4ffd4e1a91b718817742eb9b5a7b5c29a90#diff-2bafce15cac72329fb12f66603e07a3f7535df2e6225944be07a5729ca914eebL280-R294
And the changes appear fairly mechanical and *should* not be changing behavior, although it looks like from the above discussion there are some unexpected functionality changes. For the `tileSizes` variant you would just set the tile sizes option instead of numThreads.
(Not suggesting that you shouldn't raise concerns if you have them, just giving one data point).
https://github.com/llvm/llvm-project/pull/91878
More information about the Mlir-commits
mailing list