[Mlir-commits] [mlir] [mlir][vector] Add `SwapShapeCastOfTranspose` canonicalizer pattern (PR #100933)

llvmlistbot at llvm.org llvmlistbot at llvm.org
Wed Jul 31 22:52:54 PDT 2024


MaheshRavishankar wrote:

> Probably good to get feedback from @MaheshRavishankar as this topic is sensitive. I don't have a strong opinion but I think we left unit dims out of the canonicalization scope because we may lose information in some cases and for that reason we have the drop unit dim passes/patterns taking that responsibility. I would advocate for consistency if there isn't a strong case to go otherwise so that we have all the unit dims in a single place.

Thanks for checking @dcaballe 

https://github.com/llvm/llvm-project/pull/100933


More information about the Mlir-commits mailing list