[Mlir-commits] [mlir] [mlir][linalg] Relax tensor.extract vectorization (PR #99299)

Diego Caballero llvmlistbot at llvm.org
Wed Jul 31 19:00:40 PDT 2024


dcaballe wrote:

> > Hey! I was looking at the changes and thinking that we may end up introducing too much complexity if we add support for all these unit dimension special cases.
> 
> Thanks for taking a look! Note that this is actual simplifying the current logic 😅 (and reducing the number of special cases).

The way I see it is that it's replacing an early exit with a special case.

Would you have an example of how the gather would look like after vectorization and after removing the unit dim? That would be helpful to make a call.

https://github.com/llvm/llvm-project/pull/99299


More information about the Mlir-commits mailing list