[Mlir-commits] [mlir] [mlir][Transforms] Dialect conversion: Add missing "else if" branch (PR #101148)

[Matthias Springer]

matthias-springer wrote:

We don't know yet if this is a regression or incorrect API usage in your code base. So far, I can't see any problem with this commit.

(1) If this is a regression: Merge #101318, what's still missing is a test case.

(2) If this is not a regression: Fix broken code.

I know this is blocking your LLVM integrate, but this commit fixes a bug that blocked another project's (IREE) LLVM integrate, so rolling back is not ideal.

Ideally, I'd like to merge #101318 only with a test case. Our test coverage of the dialect conversion framework in MLIR is not good, and that's the reason why we have breakages like this one. So I'd say the next step is to write an MLIR-only reproducer. Then I can merge this first thing tomorrow morning. Waiting for @akuegel or @anlunx...


https://github.com/llvm/llvm-project/pull/101148