[Mlir-commits] [mlir] [mlir][spirv] Fix tablegen generator script's stripping of prefixes (PR #101378)

[llvmlistbot at llvm.org]

llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-mlir

Author: Andrea 🦈 (andfau-amd)

<details>
<summary>Changes</summary>

This script looks for existing definitions with the `SPIRV_` prefix, so that it can preserve them when updating the file. When the commit 2d628330482e49d36744cb8f3fb5047cfeae6c56 changed the prefix from `SPV_`, the number of characters to strip from matched names was not updated, which broke this feature. This commit fixes remaining cases that weren't fixed by 339c87a8a086347bd8b5aae8b5bc43fc1c155cc1.

The relationship of this script to the files it is meant to maintain is still bitrotten in other ways.

---
Full diff: https://github.com/llvm/llvm-project/pull/101378.diff


1 Files Affected:

- (modified) mlir/utils/spirv/gen_spirv_dialect.py (+4-4) 


``````````diff
diff --git a/mlir/utils/spirv/gen_spirv_dialect.py b/mlir/utils/spirv/gen_spirv_dialect.py
index 426bfca1b4f88..94d0a75c4f714 100755
--- a/mlir/utils/spirv/gen_spirv_dialect.py
+++ b/mlir/utils/spirv/gen_spirv_dialect.py
@@ -536,7 +536,7 @@ def gen_instr_coverage_report(path, instructions):
 
     content = content.split(AUTOGEN_OPCODE_SECTION_MARKER)
 
-    existing_opcodes = [k[11:] for k in re.findall("def SPIRV_OC_\w+", content[1])]
+    existing_opcodes = [k[13:] for k in re.findall("def SPIRV_OC_\w+", content[1])]
     existing_instructions = list(
         filter(lambda inst: (inst["opname"] in existing_opcodes), instructions)
     )
@@ -637,7 +637,7 @@ def update_td_enum_attrs(path, operand_kinds, filter_list):
     assert len(content) == 3
 
     # Extend filter list with existing enum definitions
-    existing_kinds = [k[8:-4] for k in re.findall("def SPIRV_\w+Attr", content[1])]
+    existing_kinds = [k[10:-4] for k in re.findall("def SPIRV_\w+Attr", content[1])]
     filter_list.extend(existing_kinds)
 
     capability_mapping = get_capability_mapping(operand_kinds)
@@ -959,12 +959,12 @@ def extract_td_op_info(op_def):
       - A dict containing potential manually specified sections
     """
     # Get opname
-    opname = [o[8:-2] for o in re.findall("def SPIRV_\w+Op", op_def)]
+    opname = [o[10:-2] for o in re.findall("def SPIRV_\w+Op", op_def)]
     assert len(opname) == 1, "more than one ops in the same section!"
     opname = opname[0]
 
     # Get instruction category
-    inst_category = [o[4:] for o in re.findall("SPIRV_\w+Op", op_def.split(":", 1)[1])]
+    inst_category = [o[6:] for o in re.findall("SPIRV_\w+Op", op_def.split(":", 1)[1])]
     assert len(inst_category) <= 1, "more than one ops in the same section!"
     inst_category = inst_category[0] if len(inst_category) == 1 else "Op"
 

``````````

</details>


https://github.com/llvm/llvm-project/pull/101378