[Mlir-commits] [mlir] [mlir][Transforms] Dialect conversion: Add missing "else if" branch (PR #101148)

Matthias Springer llvmlistbot at llvm.org
Wed Jul 31 05:30:49 PDT 2024


matthias-springer wrote:

> Also we have other internal failing tests, it seems they would also be fixed with your https://github.com/llvm/llvm-project/pull/101318

So is this a solution that would fix everything?

We still need some kind of reproducer to understand what's going on here (and to prevent this from breaking again in the future). Can you copy together some patterns and IR (only the part that's needed to reproduce this) from your code base that triggers the issue? Maybe not the `tf.While` one but another one that's a bit simpler.

I'd like to put a test in `TestPatterns.cpp` and `test-legalize-type-conversion.mlir`.


https://github.com/llvm/llvm-project/pull/101148


More information about the Mlir-commits mailing list