[Mlir-commits] [mlir] [mlir][Transforms] Dialect conversion: Add missing "else if" branch (PR #101148)

[Adrian Kuegel]

akuegel wrote:

Agree, in the first two listings it looks like nothing was modified. This starts happening with the revision from the PR. The second listing is with your https://github.com/llvm/llvm-project/pull/101318 patched in, but this also matches the behavior from before this PR.
Not sure whether I used the right debug flag (I passed the flag -log-actions-to=- to tf-opt)

```
[thread tf-opt] begins (no breakpoint) Action `pass-execution` running `LowerStaticTensorListPass` on Operation `builtin.module` (module {...})` 
           2: [thread tf-opt] completed `pass-execution` 
           3: module { 
           4: } 
           5:  
           6: // ----- 
           7: [thread tf-opt] begins (no breakpoint) Action `pass-execution` running `LowerStaticTensorListPass` on Operation `builtin.module` (module {...})` 
           8: [thread tf-opt] begins (no breakpoint) Action `apply-pattern pattern: mlir::(anonymous namespace)::ConvertTensorListFromTensor (%0 = "tf.TensorListFromTensor"(%arg0, %cst) : (tensor<2x3xf32>, tensor<1xi32>) -> tensor<!tf_type.variant<tensor<3xf32>>>)` 
           9: [thread tf-opt] completed `apply-pattern` 
          10: [thread tf-opt] begins (no breakpoint) Action `apply-pattern pattern: mlir::(anonymous namespace)::ConvertWhile (%1:2 = "tf.While"(%cst_0, %0) <{body = @tensorlistWhileBody, cond = @tensorlistWhileCond, is_stateless = false}> {T = ["tfdtype$DT_INT32", "tfdtype$DT_VARIANT"]} : (tensor<i32>, tensor<!tf_type.variant<tensor<3xf32>>>) -> (tensor<i32>, tensor<!tf_type.variant<tensor<*xf32>>>))` 
          11: [thread tf-opt] completed `apply-pattern` 
          12: [thread tf-opt] begins (no breakpoint) Action `apply-pattern pattern: mlir::(anonymous namespace)::ConvertTensorListStack (%3 = "tf.TensorListStack"(%2#1, %cst_1) : (tensor<!tf_type.variant<tensor<*xf32>>>, tensor<i32>) -> tensor<2x3xf32>)` 
          13: [thread tf-opt] completed `apply-pattern` 
          14: [thread tf-opt] begins (no breakpoint) Action `apply-pattern pattern: mlir::(anonymous namespace)::ConvertTensorListLength (%2 = "tf.TensorListLength"(<<UNKNOWN SSA VALUE>>) : (tensor<!tf_type.variant>) -> tensor<i32>)` 
          15: [thread tf-opt] completed `apply-pattern` 
          16: [thread tf-opt] begins (no breakpoint) Action `apply-pattern pattern: mlir::(anonymous namespace)::ConvertIdentity (%7 = "tf.Identity"(<<UNKNOWN SSA VALUE>>) : (tensor<!tf_type.variant>) -> tensor<!tf_type.variant>)` 
          17: [thread tf-opt] completed `apply-pattern` 
          18: [thread tf-opt] completed `pass-execution` 
```

https://github.com/llvm/llvm-project/pull/101148