[Mlir-commits] [mlir] [mlir][Transforms] Dialect conversion: Add missing "else if" branch (PR #101148)

[Matthias Springer]

matthias-springer wrote:

That could work, but we should then probably build the argument materialization only when there is a type converter. When there is none, and the number of replArgs is 1, directly take that argument and do not build any materializations. But I'd like to understand first why the current implementation does not work. I don't see any conceptual problem with it.

Can you provide a reproducer that can run with upstream MLIR? We really have to improve our test coverage of the dialect conversion framework.


https://github.com/llvm/llvm-project/pull/101148