[Mlir-commits] [mlir] [mlir] Add support for parsing nested PassPipelineOptions (PR #101118)
River Riddle
llvmlistbot at llvm.org
Tue Jul 30 09:22:45 PDT 2024
================
@@ -187,13 +211,15 @@ LogicalResult detail::pass_options::parseCommaSeparatedList(
size_t nextElePos = findChar(optionStr, 0, ',');
while (nextElePos != StringRef::npos) {
// Process the portion before the comma.
- if (failed(elementParseFn(optionStr.substr(0, nextElePos))))
+ if (failed(
+ elementParseFn(extractArgAndUpdateOptions(optionStr, nextElePos))))
return failure();
- optionStr = optionStr.substr(nextElePos + 1);
+ optionStr = optionStr.drop_front(); // drop the leading ','
----------------
River707 wrote:
```suggestion
// Drop the leading ','.
optionStr = optionStr.drop_front();
```
Prefer non-trailing comments.
https://github.com/llvm/llvm-project/pull/101118
More information about the Mlir-commits
mailing list