[Mlir-commits] [mlir] [mlir][doc] Fix docs for `PtrDialect` using the `-gen-dialect-doc`(NFC) (PR #101013)

Kohei Yamaguchi llvmlistbot at llvm.org
Mon Jul 29 07:36:50 PDT 2024


https://github.com/sott0n updated https://github.com/llvm/llvm-project/pull/101013

>From 887c985ca7cf94e6af101789037b5f856ef0103f Mon Sep 17 00:00:00 2001
From: Kohei Yamaguchi <fix7211 at gmail.com>
Date: Mon, 29 Jul 2024 22:38:55 +0900
Subject: [PATCH 1/2] [mlir][doc] Fix docs for `PtrDialect` using the
 `-gen-dialect-doc`(NFC)

The `-gen-op-doc` option was previously used, which did not generate
a page for `PtrDialect` and resulted in an empty page. Switched to
using the `-gen-dialect-doc` option to correctly generate a page
for `PtrDialect` that includes information on its Attributes and Types.
---
 mlir/include/mlir/Dialect/Ptr/IR/CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mlir/include/mlir/Dialect/Ptr/IR/CMakeLists.txt b/mlir/include/mlir/Dialect/Ptr/IR/CMakeLists.txt
index df07b8d5a63d9..529ce827f4762 100644
--- a/mlir/include/mlir/Dialect/Ptr/IR/CMakeLists.txt
+++ b/mlir/include/mlir/Dialect/Ptr/IR/CMakeLists.txt
@@ -1,5 +1,5 @@
 add_mlir_dialect(PtrOps ptr)
-add_mlir_doc(PtrOps PtrOps Dialects/ -gen-op-doc)
+add_mlir_doc(PtrOps PtrOps Dialects/ -gen-dialect-doc)
 
 set(LLVM_TARGET_DEFINITIONS PtrOps.td)
 mlir_tablegen(PtrOpsAttrs.h.inc -gen-attrdef-decls -attrdefs-dialect=ptr)

>From 75b7576bedad081e998e5cfe66825907deeba217 Mon Sep 17 00:00:00 2001
From: Kohei Yamaguchi <fix7211 at gmail.com>
Date: Mon, 29 Jul 2024 23:36:43 +0900
Subject: [PATCH 2/2] update

Co-authored-by: Fabian Mora <fmora.dev at gmail.com>
---
 mlir/include/mlir/Dialect/Ptr/IR/CMakeLists.txt | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mlir/include/mlir/Dialect/Ptr/IR/CMakeLists.txt b/mlir/include/mlir/Dialect/Ptr/IR/CMakeLists.txt
index 529ce827f4762..82938962fb939 100644
--- a/mlir/include/mlir/Dialect/Ptr/IR/CMakeLists.txt
+++ b/mlir/include/mlir/Dialect/Ptr/IR/CMakeLists.txt
@@ -1,5 +1,5 @@
 add_mlir_dialect(PtrOps ptr)
-add_mlir_doc(PtrOps PtrOps Dialects/ -gen-dialect-doc)
+add_mlir_doc(PtrOps PtrOps Dialects/ -gen-dialect-doc -dialect=ptr)
 
 set(LLVM_TARGET_DEFINITIONS PtrOps.td)
 mlir_tablegen(PtrOpsAttrs.h.inc -gen-attrdef-decls -attrdefs-dialect=ptr)



More information about the Mlir-commits mailing list