[Mlir-commits] [mlir] [MLIR][Vector] Add a test of <2x[4]xf32> type on lowering multireduction (PR #100451)

[Andrzej Warzyński]

================
@@ -298,6 +298,30 @@ func.func @scalable_dim_1d(%A: vector<[4]xf32>, %B: f32, %C: vector<[4]xi1>) ->
 // CHECK:          %[[VAL_4:.*]] = vector.extract %[[VAL_3]][0] : f32 from vector<1xf32>
 // CHECK:          return %[[VAL_4]] : f32
 
+func.func @scalable_dim_2d(%A: vector<2x[4]xf32>, %B: vector<2xf32>, %C: vector<2x[4]xi1>) -> vector<2xf32> {
----------------
banach-space wrote:

Thanks! This would be a bit clearer:
vector_multi_reduction_non_scalable_reduction_dim
vector_multi_reduction_scalable_reduction_dim_1d
vector_multi_reduction_scalable_reduction_dim_2d

Accepting as is, no need to bikeshed.

https://github.com/llvm/llvm-project/pull/100451