[Mlir-commits] [mlir] [mlir][Transforms] Dialect conversion: Simplify handling of dropped arguments (PR #97213)

[Scott Todd]

================

----------------
ScottTodd wrote:

We're seeing asserts downstream after this PR that go away if the commit is reverted.

```
mlir/lib/IR/Region.cpp:25: MLIRContext *mlir::Region::getContext(): Assertion `container && "region is not attached to a container"' failed.
```

Logs:
* https://github.com/iree-org/iree/actions/runs/10085263103/job/27885739686#step:4:8313 
* https://gist.github.com/ScottTodd/f384487731a2af7afe2c1e55bcc62e25

IR before the pass that crashes for one test case: https://gist.github.com/ScottTodd/6a9fdc0976d7336291d61ccf24bcb22b

Our downstream code involved in the callstack is here: https://github.com/iree-org/iree/blob/main/compiler/src/iree/compiler/InputConversion/Common/ConvertPrimitiveType.cpp . I'm not sure yet if our usage downstream needs to change or if there is a bug in this upstream code. Do you have any suggestions?

https://github.com/llvm/llvm-project/pull/97213