[Mlir-commits] [flang] [mlir] [MLIR][OpenMP][Flang] Normalize clause arguments names (PR #99505)
Michael Kruse
llvmlistbot at llvm.org
Wed Jul 24 07:27:23 PDT 2024
================
@@ -32,37 +32,37 @@ namespace omp {
struct AlignedClauseOps {
llvm::SmallVector<Value> alignedVars;
- llvm::SmallVector<Attribute> alignmentAttrs;
+ llvm::SmallVector<Attribute> alignments;
};
struct AllocateClauseOps {
- llvm::SmallVector<Value> allocatorVars, allocateVars;
+ llvm::SmallVector<Value> allocateVars, allocatorVars;
};
struct CancelDirectiveNameClauseOps {
- ClauseCancellationConstructTypeAttr cancelDirectiveNameAttr;
+ ClauseCancellationConstructTypeAttr cancelDirective;
};
struct CollapseClauseOps {
- llvm::SmallVector<Value> loopLBVar, loopUBVar, loopStepVar;
+ llvm::SmallVector<Value> collapseLowerBound, collapseUpperBound, collapseStep;
----------------
Meinersbur wrote:
That indeed sounds better. I leave it up to you what you feel is less work.
For me either one means I will have to rebase my work again anyway.
https://github.com/llvm/llvm-project/pull/99505
More information about the Mlir-commits
mailing list