[Mlir-commits] [mlir] [mlir] Add property combinators, initial ODS support (PR #94732)

Krzysztof Drewniak llvmlistbot at llvm.org
Tue Jul 23 12:12:19 PDT 2024


krzysz00 wrote:

Agreed that this could probably be multiple PRs - this is a change that grew, honestly. I can go looking for split points.

@Mogball , on the topic of the change growing, I was thinking that support for something like `ConstrainedProp` would be a good idea. One thing I noticed is that there's a very old TODO about unifying `Pred` and `Constraint` - do you think it'd make sense to, for example, add a `Pred predicate` field to property classes instead of dealing in `Constraint`? Or to make a `ConstrainedProp` that takes a `Pred`?

https://github.com/llvm/llvm-project/pull/94732


More information about the Mlir-commits mailing list